Re: [PATCH v1 1/1] intel-mid_wdt: make sure watchdog is not running at startup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2016-11-18 at 07:50 -0800, Guenter Roeck wrote:
> On 11/18/2016 06:50 AM, Andy Shevchenko wrote:
> > Make sure that the watchdog is not running after loading
> > and before it is started by opening /dev/watchdog.

@@ -151,6 +151,9 @@ static int mid_wdt_probe(struct platform_device

> > +	/* Make sure the watchdog is not running */
> > +	wdt_stop(wdt_dev);
> > +
> >  	ret = watchdog_register_device(wdt_dev);

> This leaves the system exposed. Why not just tell the core if the
> watchdog
> is running and let it handle the ping until the device is opened ?
> Is it not possible to detect if the watchdog is running ?

It would be nice to have, but...

Just checked all documents I have access to. They even didn't describe a
content of watchdog IPC command!

So, we may just assume it's enabled by firmware until it is proven not
to. 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux