Re: [PATCH] watchdog: Remove misleading word "legacy" for /dev/watchdog

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/16/2016 03:49 AM, Robert P. J. Day wrote:
The word "legacy" should not be used for the special file
/dev/watchdog, as that file is still essential for watchdog
operations.


NAK. The non-legacy name is /dev/watchdog0.

Guenter

Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>

---

  i expressed my reservations about use of the word "legacy" here:

https://lists.kernelnewbies.org/pipermail/kernelnewbies/2016-October/017054.html

diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
index 32930a0..0cc5ab8 100644
--- a/drivers/watchdog/watchdog_dev.c
+++ b/drivers/watchdog/watchdog_dev.c
@@ -891,7 +891,7 @@ static struct miscdevice watchdog_miscdev = {
  *	@wdd: watchdog device
  *	@devno: character device number
  *
- *	Register a watchdog character device including handling the legacy
+ *	Register a watchdog character device including handling the
  *	/dev/watchdog node. /dev/watchdog is actually a miscdevice and
  *	thus we set it up like that.
  */
@@ -968,7 +968,7 @@ static int watchdog_cdev_register(struct watchdog_device *wdd, dev_t devno)
  *	watchdog_cdev_unregister: unregister watchdog character device
  *	@watchdog: watchdog device
  *
- *	Unregister watchdog character device and if needed the legacy
+ *	Unregister watchdog character device and if needed the
  *	/dev/watchdog device.
  */

@@ -1002,7 +1002,7 @@ static struct class watchdog_class = {
  *	watchdog_dev_register: register a watchdog device
  *	@wdd: watchdog device
  *
- *	Register a watchdog device including handling the legacy
+ *	Register a watchdog device including handling the
  *	/dev/watchdog node. /dev/watchdog is actually a miscdevice and
  *	thus we set it up like that.
  */
@@ -1040,7 +1040,7 @@ int watchdog_dev_register(struct watchdog_device *wdd)
  *	watchdog_dev_unregister: unregister a watchdog device
  *	@watchdog: watchdog device
  *
- *	Unregister watchdog device and if needed the legacy
+ *	Unregister watchdog device and if needed the
  *	/dev/watchdog device.
  */



--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux