On Mon, Aug 29, 2016 at 10:58:57PM +0300, Vladimir Zapolskiy wrote:
> On 08/29/2016 09:50 PM, Wolfram Sang wrote:
> >>+ } else {
> >> wdd->timeout = timeout;
> >>+ /* Disable pretimeout if it doesn't fit the new timeout */
> >>+ if (wdd->pretimeout >= wdd->timeout)
> >>+ wdd->pretimeout = 0;
> >
> >I wonder if we should add a warning here? What do you think?
> >
>
> IMHO it is not vitally needed, but some message on KERN_INFO level may
> be considered as user-friendly, watchdog subsystem and drivers are
> historically verbose. Guenter, do you have an opinion on the topic?
>
Yes, I dislike noise, I think the kernel is already way too noisy, and I dislike
statements like "watchdog subsystem and drivers are historically verbose" as
argument for adding more noise.
If this is an error, the function should return an error to user space.
If it isn't an error, I don't see a need for a message.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
