Re: [PATCH v3 3/3] watchdog: qcom: configure BARK time in addition to BITE time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Matthew,

> From: Matthew McClintock <mmcclint@xxxxxxxxxxxxxx>
> 
> For certain parts and some versions of TZ, TZ will reset the chip
> when a BARK is triggered even though it was not configured here. So
> by default let's configure this BARK time as well.
> 
> Signed-off-by: Matthew McClintock <mmcclint@xxxxxxxxxxxxxx>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Thomas Pedersen <twp@xxxxxxxxxxxxxx>
> ---
>  drivers/watchdog/qcom-wdt.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c
> index 111e8a7..5796b5d 100644
> --- a/drivers/watchdog/qcom-wdt.c
> +++ b/drivers/watchdog/qcom-wdt.c
> @@ -24,6 +24,7 @@ enum wdt_reg {
>  	WDT_RST,
>  	WDT_EN,
>  	WDT_STS,
> +	WDT_BARK_TIME,
>  	WDT_BITE_TIME,
>  };
>  
> @@ -31,6 +32,7 @@ static const u32 reg_offset_data_apcs_tmr[] = {
>  	[WDT_RST] = 0x38,
>  	[WDT_EN] = 0x40,
>  	[WDT_STS] = 0x44,
> +	[WDT_BARK_TIME] = 0x4C,
>  	[WDT_BITE_TIME] = 0x5C,
>  };
>  
> @@ -38,6 +40,7 @@ static const u32 reg_offset_data_kpss[] = {
>  	[WDT_RST] = 0x4,
>  	[WDT_EN] = 0x8,
>  	[WDT_STS] = 0xC,
> +	[WDT_BARK_TIME] = 0x10,
>  	[WDT_BITE_TIME] = 0x14,
>  };
>  
> @@ -66,6 +69,7 @@ static int qcom_wdt_start(struct watchdog_device *wdd)
>  
>  	writel(0, wdt_addr(wdt, WDT_EN));
>  	writel(1, wdt_addr(wdt, WDT_RST));
> +	writel(wdd->timeout * wdt->rate, wdt_addr(wdt, WDT_BARK_TIME));
>  	writel(wdd->timeout * wdt->rate, wdt_addr(wdt, WDT_BITE_TIME));
>  	writel(1, wdt_addr(wdt, WDT_EN));
>  	return 0;
> @@ -108,6 +112,7 @@ static int qcom_wdt_restart(struct watchdog_device *wdd, unsigned long action,
>  
>  	writel(0, wdt_addr(wdt, WDT_EN));
>  	writel(1, wdt_addr(wdt, WDT_RST));
> +	writel(timeout, wdt_addr(wdt, WDT_BARK_TIME));
>  	writel(timeout, wdt_addr(wdt, WDT_BITE_TIME));
>  	writel(1, wdt_addr(wdt, WDT_EN));
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

This patch has been added to linux-watchdog-next.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux