Re: [PATCH v2 1/2] watchdog: add pretimeout support to the core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Nitpick: If we consider pretimeout == timeout to be invalid, we should reject it here
> as well. So this should be >=.

I agree to that.

> to the next version. I'd suggest to wait a bit to give Wolfram time to provide input,
> though.

I liked the is_visible() change right away, so these patches are fine.
Guenter, what is your take on upstreaming the softdog pretimeout
support? I'd think it would be good to have for testing purposes. It
would also help me to upstream the busybox patch for the watchdog
applet.

Thanks,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux