On Fri, Jun 17, 2016 at 05:12:05PM +0000, weiyj_lk@xxxxxxx wrote: > From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > > In case of error, the function devm_kzalloc() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should > be replaced with NULL test. > > Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > --- > drivers/watchdog/pic32-dmt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/pic32-dmt.c b/drivers/watchdog/pic32-dmt.c > index 962f58c..5e8890e 100644 > --- a/drivers/watchdog/pic32-dmt.c > +++ b/drivers/watchdog/pic32-dmt.c > @@ -176,8 +176,8 @@ static int pic32_dmt_probe(struct platform_device *pdev) > struct watchdog_device *wdd = &pic32_dmt_wdd; > > dmt = devm_kzalloc(&pdev->dev, sizeof(*dmt), GFP_KERNEL); > - if (IS_ERR(dmt)) > - return PTR_ERR(dmt); > + if (!dmt) > + return -ENOMEM; > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > dmt->regs = devm_ioremap_resource(&pdev->dev, mem); > > > -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
