Re: [PATCHv2] watchdog: stmp3xxx: Implement GETBOOTSTATUS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fabio!

On Sat, 3 Oct 2015 19:13:26 -0300, Fabio Estevam <festevam@xxxxxxxxx>
wrote:
> Hi Harald,
> 
> On Sat, Oct 3, 2015 at 6:54 PM, Harald Geyer <harald@xxxxxxxxx> wrote:
>> When the watchdog is enabled, we set a persitent bit. After booting
>> we query the bit and see if the system was reset by the watchdog.
>>
>> This is somewhat similar to what the legacy driver from freescale
>> does. However we use STMP3XXX_RTC_PERSISTENT2 instead of
>> STMP3XXX_RTC_PERSISTENT1. I tried that first, but it seems I can't
>> clear the bit there once it is set. I didn't find any documentation
>> what this register does - only vague hints that it is meant to
>> control the boot ROM.
>>
>> Part of the code from the legacy driver touching this register
>> is still included. Maybe this is stale, but this patch doesn't
>> touch any of it because I don't know what it really does or is
>> meant to do.
>>
>> Signed-off-by: Harald Geyer <harald@xxxxxxxxx>
> 
> I read your commit log, but it is not clear for me what is the real
> issue you are trying to solve with this patch.

The purpose of the patch is to implement the GETBOOTSTATUS ioctl on
this device, so that userspace can check if the last reboot was caused
by the watchdog.

Since I don't completely understand the code I'm modifying, I wrote
the rather lenghty commit message to document what I know:

* The feature this patch implements was already present in the BSP
* Following the implementation of the BSP didn't work for me
  (Maybe it works with some other boot method - I can't tell
   without better documentation. I'm using uboot, not bootlets.)
* Some bits of the code from the BSP are present in the current
  mainline kernel. I don't know if this code is doing anything
  useful.

HTE,
Harald
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux