Hi, On 02/10/2015 at 20:18:02 +0000, Harald Geyer wrote : > +static void stmp3xxx_wdt_clear_bootstatus(struct device *dev) > +{ > + struct stmp3xxx_rtc_data *rtc_data = dev_get_drvdata(dev); > + > + writel(STMP3XXX_RTC_PERSISTENT2_WDT_ACTIVE, > + STMP3XXX_RTC_PERSISTENT2 + STMP_OFFSET_REG_CLR + rtc_data->io); nitpick: I would put rtc_data->io first here for consistency. Else, this seems fine to me, I can take that patch with the watchdog maintainers ack. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html