Re: [PATCH v1 3/5] watchdog: mpc8xxx: make use of of_device_get_match_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uwe,

On 08/10/2015 12:24 AM, Uwe Kleine-König wrote:
Hello Guenter,

On Fri, Aug 07, 2015 at 07:56:51AM -0700, Guenter Roeck wrote:
  	enabled = in_be32(&wd_base->swcrr) & SWCRR_SWEN;
  	if (!enabled && wdt_type->hw_enabled) {
  		pr_info("could not be enabled in software\n");
-		ret = -ENOSYS;
-		goto err_unmap;
+		return -ENOSYS;
  	}

checkpatch says:

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
#65: FILE: drivers/watchdog/mpc8xxx_wdt.c:166:
+		return -ENOSYS;

Maybe just use -ENODEV.
That would be a separate patch tough because I'm just changing the code
flow and ENOSYS was there already before.

Since you are at it, can you add a patch to do that ?

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux