2015-08-06 17:24 GMT+08:00 Guenter Roeck <linux@xxxxxxxxxxxx>: > > On 08/06/2015 01:31 AM, Barry Song wrote: >> >> From: William Wang <William.Wang@xxxxxxx> >> >> This patch adds support for the new CSR atlas7 chips. prima2 and atlas7 >> are similar in chip design, but the register layout and flows have some >> differences. >> >> This patch puts the differences including register layout and operations >> in dt private data, so that one driver can be compatible for two chips. >> >> Signed-off-by: William Wang <William.Wang@xxxxxxx> >> Signed-off-by: Guo Zeng <guo.zeng@xxxxxxx> >> Signed-off-by: Barry Song <Baohua.Song@xxxxxxx> > > > You are pretty much doubling the size of this driver (from 225 to 446 LOC). > I don't see the benefits of having a single driver, sorry. It just makes > it very difficult to maintain. Please make this a separate driver. the problem is that atlas7 and prima2 shares same watchdog IP, but the way to implemen the driver has some differences due to different authors. we are going to unify the implementation of prima2 and atlas7, then those callbacks can be shared. and then the code size will not be doubled. > > Thanks, > Guenter > -barry -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
