Hi Vivien, On Wed, Jun 17, 2015 at 06:58:58PM -0400, Vivien Didelot wrote: > This patch removes the static watchdog device for a new max63xx_wdt data > structure, and constifies the max63xx_timeout data. > > The new structure contains pointers to pin access routines, which > abstracts mmap-specific code. This will ease future accesses like GPIO. > > Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx> Looks good. Minor nitpick below, but not worth a new version. Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > --- > drivers/watchdog/max63xx_wdt.c | 170 +++++++++++++++++++++++++---------------- > 1 file changed, 104 insertions(+), 66 deletions(-) > > diff --git a/drivers/watchdog/max63xx_wdt.c b/drivers/watchdog/max63xx_wdt.c > index b3a1130..3f7e8d5 100644 > --- a/drivers/watchdog/max63xx_wdt.c > +++ b/drivers/watchdog/max63xx_wdt.c > @@ -39,10 +39,22 @@ static bool nowayout = WATCHDOG_NOWAYOUT; > #define MAX6369_WDSET (7 << 0) > #define MAX6369_WDI (1 << 3) > > -static DEFINE_SPINLOCK(io_lock); > +#define MAX6369_WDSET_DISABLED 3 I would have used a tab before '3'. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
