Re: [PATCH] watchdog: mena21_wdt: Fix possible NULL pointer dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 02, 2015 at 06:44:48AM -0700, Guenter Roeck wrote:
> On 06/02/2015 03:25 AM, Johannes Thumshirn wrote:
> >In a21_wdt_remove() we do a watchdog_unregister_device() on struct
> >a21_wdt_drv->wdt but never assign it.
> >
> >Also move the dev_set_drvdata() call in front of the watchdog_register_device()
> >call, so it doesn't look like an error.
> >
> >Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
> 
> Good catch.
> 
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> 
> Guenter
> 

Hi Wim,

Any objections to this one? Do you intent to take it for 4.2?

Thanks,
	Johannes

-- 
Johannes Thumshirn                                       Storage
jthumshirn@xxxxxxx                             +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux