On Friday 15 May 2015 19:08:05 fu.wei@xxxxxxxxxx wrote: > From: Fu Wei <fu.wei@xxxxxxxxxx> > > The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for > introducing SBSA(Server Base System Architecture) Generic Watchdog > device node info into FDT > > Signed-off-by: Fu Wei <fu.wei@xxxxxxxxxx> Looks good, just one minor comment: > +Optional properties > +- timeout-sec : Watchdog pre-timeout and timeout values (in seconds). > + The first is timeout values, then pre-timeout. Please update Documentation/watchdog/watchdog-kernel-api.txt as well, to mention the second number in the timeout-sec property. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html