On 04/24/2015 12:03 PM, Uwe Kleine-König wrote:
On Fri, Apr 24, 2015 at 11:48:33AM +0200, Uwe Kleine-König wrote:
Instead of using an over-long expression involving the ?: operator use
an if and intead of an else branch rely on the fact that the data
just noticed ^^ there is an s missing ...
Wim, if you apply this version, can you fix that up?
Hi Uwe,
if you don't mind, can you sesend the entire series ?
I don't think patch 1 applies after 1a, and it might make sense
to add some more explanation to patch 2. FWIW, I would say that using
to_omap_wdt_dev() instead of watchdog_get_drvdata() simplifies the code,
or simply that the functions are no longer needed in the driver (ugliness
may be seen as personal opinion).
When you do so, please feel free to add
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> to all four patches.
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
