Re: [PATCH 2/2] watchdog: imgpdc: Fix default heartbeat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 20, 2015 at 11:45:45PM +0000, James Hogan wrote:
> The IMG PDC watchdog driver heartbeat module parameter has no default so
> it is initialised to zero. This results in the following warning during
> probe:
> 
> imgpdc-wdt 2006000.wdt: Initial timeout out of range! setting max timeout
> 
> The module parameter description implies that the default value should
> be PDC_WDT_DEF_TIMEOUT, which isn't yet used, so initialise it to that.
> 
> Also tweak the heartbeat module parameter description for consistency.
> 
> Fixes: 93937669e9b5 ("watchdog: ImgTec PDC Watchdog Timer Driver")
> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
> Cc: Wim Van Sebroeck <wim@xxxxxxxxx>
> Cc: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxx>
> Cc: Naidu Tellapati <Naidu.Tellapati@xxxxxxxxxx>
> Cc: Jude Abraham <Jude.Abraham@xxxxxxxxxx>
> Cc: linux-watchdog@xxxxxxxxxxxxxxx

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux