On Tue, Apr 08, 2014 at 04:56:36PM -0700, Randy Dunlap wrote: > On 04/08/2014 01:59 PM, David Cohen wrote: > > Add initial Intel MID watchdog driver support. > > > > This driver is an initial implementation of generic Intel MID watchdog > > driver. Currently it supports Intel Merrifield platform. > > > > Signed-off-by: Eric Ernst <eric.ernst@xxxxxxxxx> > > Signed-off-by: David Cohen <david.a.cohen@xxxxxxxxxxxxxxx> > > --- > > drivers/watchdog/Kconfig | 12 +++ > > drivers/watchdog/Makefile | 1 + > > drivers/watchdog/intel-mid_wdt.c | 209 +++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 222 insertions(+) > > create mode 100644 drivers/watchdog/intel-mid_wdt.c > > > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > > index 79d25894343a..4da09b8b2f11 100644 > > --- a/drivers/watchdog/Kconfig > > +++ b/drivers/watchdog/Kconfig > > @@ -643,6 +643,18 @@ config INTEL_SCU_WATCHDOG > > > > To compile this driver as a module, choose M here. > > > > +config INTEL_MID_WATCHDOG > > + bool "Intel MID SCU Watchdog Mobile Platforms" > > + depends on X86_INTEL_MID && WATCHDOG_CORE > > + ---help--- > > + Watchdog timer driver built into the Intel SCU for Intel MID > > + Platforms. > > + > > + This driver currently supports only the watchdog evolution > > + implementation in SCU, available for Merrifield generation. > > + > > + To compile this driver as a module, choose M here. > > Does choosing M work when INTEL_MID_WATCHDOG is a bool? > and why is INTEL_MID_WATCHDOG a bool? The error here is the left over line from the template I used. There should be no mention about choosing M. It's bool because the watchdog is started by default on fw. We need this driver probed during boot to pet/kick/ping asap. IMHO It makes not much sense to compile it as module. Br, David > > > + > > config ITCO_WDT > > tristate "Intel TCO Timer/Watchdog" > > depends on (X86 || IA64) && PCI > > > -- > ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
