Re: [PATCH 0/2] Watchdog on Armada 375 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 26, 2014 at 09:50:45AM -0300, Ezequiel Garcia wrote:
 
> Here we found both the above RSTOUT:
> 
> 1. It has the same dedicated register as A370/XP (0x20704)
> 2. Also has a bit in the shared RSTOUT register (0x18254)

Unless you know otherwise I think the same risk exists, RSTOUT could
be (or become) internally asserted when you unmask the bit in the
control register that drives the pin, which says the watchdog driver
should control to it.

> A possible solution is to extend the reg property in the watchdog
> devicetree and allow for a new optional pair of cells to complete
> the specification of the RSTOUT.
> 
> 	watchdog-timer@20300 {
> 		compatible = "marvell,orion-wdt";
> 		reg = <0x20300 0x28
> 		       {shared RSOUT} 0x4
> 		       0x0 0x0>;
> 	};

I wouldn't have the 0x0, if you want to go this way, just make the
375 compatible string require a 3 entry reg.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux