On Sat, Feb 15, 2014 at 01:23:25PM +0400, Alexander Shiyan wrote:
> Variable "new_margin" is checked in the function watchdog_ioctl()
> to be positive, so change its type to "int".
non-negative, really.
Other than that,
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>
> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ---
> drivers/watchdog/wdt285.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/wdt285.c b/drivers/watchdog/wdt285.c
> index 7355ddd0..ebbb183 100644
> --- a/drivers/watchdog/wdt285.c
> +++ b/drivers/watchdog/wdt285.c
> @@ -139,9 +139,8 @@ static const struct watchdog_info ident = {
> static long watchdog_ioctl(struct file *file, unsigned int cmd,
> unsigned long arg)
> {
> - unsigned int new_margin;
> int __user *int_arg = (int __user *)arg;
> - int ret = -ENOTTY;
> + int new_margin, ret = -ENOTTY;
>
> switch (cmd) {
> case WDIOC_GETSUPPORT:
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
