> -----Original Message----- > From: Michal Simek [mailto:monstr@xxxxxxxxx] > Sent: Sunday, February 09, 2014 11:04 PM > To: Guenter Roeck > Cc: Michal Simek; linux-kernel@xxxxxxxxxxxxxxx; Wim Van Sebroeck; > linux-watchdog@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 01/10] watchdog: xilinx: Convert driver to the > watchdog framework > > On 02/09/2014 09:03 PM, Guenter Roeck wrote: > > On 01/31/2014 06:18 AM, Michal Simek wrote: > >> - Remove uneeded headers, fops functions > >> - Use xilinx_wdt prefix in start/stop/keepalive functions > >> and in new structures > >> > >> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx> > > > > Hi Michal, > > > >> static int xwdt_probe(struct platform_device *pdev) > >> { > >> int rc; > >> @@ -314,7 +184,7 @@ static int xwdt_probe(struct platform_device > *pdev) > >> "xlnx,wdt-enable-once", NULL); > >> if (tmptr == NULL) { > >> pr_warn("Parameter \"xlnx,wdt-enable-once\" not found in > device tree!\n"); > >> - xdev.nowayout = WATCHDOG_NOWAYOUT; > >> + watchdog_set_nowayout(&xilinx_wdt_wdd, true); > > > > Sure you want to set this to always true instead of using > WATCHDOG_NOWAYOUT ? > > I have checked it and > option CONFIG_WATCHDOG_NOWAYOUT - Disable watchdog shutdown on close > > with this part in the header > > 100 #ifdef CONFIG_WATCHDOG_NOWAYOUT > 101 #define WATCHDOG_NOWAYOUT 1 > 102 #define WATCHDOG_NOWAYOUT_INIT_STATUS (1 << WDOG_NO_WAY_OUT) > 103 #else > 104 #define WATCHDOG_NOWAYOUT 0 > 105 #define WATCHDOG_NOWAYOUT_INIT_STATUS 0 > 106 #endif > > enable once is hardware option and it means when this option is setup > in hw you can't stop watchdog. That's why I think that setting up true > instead of WATCHDOG_NOWAYOUT is correct. > Ok, makes sense. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
