On Wed, Jan 22, 2014 at 10:50:30AM -0700, Jason Gunthorpe wrote: > On Wed, Jan 22, 2014 at 02:45:40PM -0300, Ezequiel Garcia wrote: > > > Agreed. So, let's assume we can guarantee that request_irq() does the > > job of clearing the cause register (clearing pending irqs). > > > > So, your suggestion is to put request_irq() in the watchdog start()? > > > > Otherwise, we can ensure a watchdog full stop at probe(), before > > requesting the IRQ. Both solutions should work, uh? > > Right, I would keep the request_irq in probe, just because that feels > more idiomatic.. > Done. Baking v4... -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html