Hi Wim,
On Mon, Dec 30, 2013 at 09:37:55AM +0100, Wim Van Sebroeck wrote:
> If this is ARM hardware, then this should have the dependency "depends on
> ARM".
> Only if other architectures start using this watchdog device, then the
> "depends on ARM" can go.
Well, we intend to use this driver on Xtensa platform, does this count?
As a general rule wouldn't it be better to have the widest possible build
coverage, and encourage arch neutral driver coding?
baruch
> > There is nothing ARM specific in this driver. Also, clk.h now includes
> > stubs
> > for !CONFIG_HAVE_CLK, so the driver should build anyway.
> >
> > Cc: Jamie Iles <jamie@xxxxxxxxxxxxx>
> > Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx>
> > ---
> > drivers/watchdog/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index 5be6e91..5ffac39 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -214,7 +214,6 @@ config SA1100_WATCHDOG
> >
> > config DW_WATCHDOG
> > tristate "Synopsys DesignWare watchdog"
> > - depends on ARM && HAVE_CLK
> > help
> > Say Y here if to include support for the Synopsys DesignWare
> > watchdog timer found in many ARM chips.
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
