On Mon, Sep 30, 2013 at 12:42:51PM -0000, Sachin Kamat wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>
Hi Sachin,
I understand that the driver doesn't currently support to be built as module,
so of_match_ptr() is not really necessary. But unless I am missing something,
here isn't anything wrong with it either, not does it hurt to have it in place.
So what is the benefit of this series ?
Thanks,
Guenter
> ---
> drivers/watchdog/at91rm9200_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c
> index 1c75260..aa5cb56 100644
> --- a/drivers/watchdog/at91rm9200_wdt.c
> +++ b/drivers/watchdog/at91rm9200_wdt.c
> @@ -269,7 +269,7 @@ static struct platform_driver at91wdt_driver = {
> .driver = {
> .name = "at91_wdt",
> .owner = THIS_MODULE,
> - .of_match_table = of_match_ptr(at91_wdt_dt_ids),
> + .of_match_table = at91_wdt_dt_ids,
> },
> };
>
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
