Hi Samuel, On Thu, Jun 27, 2013 at 11:47:05PM +0200, Samuel Ortiz wrote: > Hi Kevin, > > On Thu, Jun 27, 2013 at 11:23:15AM -0700, Kevin Strasser wrote: > > Hi Wim, > > > > This driver hasn't received any further feedback. Are you ready to take it > > into watchdog-next, or do you still need to review it? > I applied the watchdog patch to mfd-next and got the following warning: > > CC [M] drivers/watchdog/kempld_wdt.o > drivers/watchdog/kempld_wdt.c: In function ‘kempld_wdt_suspend’: > drivers/watchdog/kempld_wdt.c:538:3: warning: passing argument 1 of > ‘kempld_wdt_stop’ from incompatible pointer type [enabled by default] > drivers/watchdog/kempld_wdt.c:313:12: note: expected ‘struct > watchdog_device *’ but argument is of type ‘struct platform_device *’ > > I fixed it up, but I'd appreciate if you could double check that > kempld_wdt_suspend() is ok. Ah, yes you made the appropriate change. This used to be a call to kempld_wdt_shutdown, which I changed to kempld_wdt_stop to avoid the pointless redirection. Somehow I forgot to convert the argument. Thanks, Kevin > > Cheers, > Samuel. > > -- > Intel Open Source Technology Centre > http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
