On Tue, Jun 18, 2013 at 9:11 AM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: > On 18/06/13 16:42, Guenter Roeck wrote: >> On Tue, Jun 18, 2013 at 08:50:25PM +0530, Viresh Kumar wrote: >>> This driver was broken since ever. >>> >>> - Interrupt request doesn't use the right API: The TWD watchdog uses a per-cpu >>> interrupt (usually interrupt #30), and the GIC configuration should flag it as >>> such. With this setup, request_irq() should fail, and the right API is >>> request_percpu_irq(), together with enable_percpu_irq()/disable_percpu_irq(). >>> >>> - Nothing ensures the userspace ioctl() will end-up kicking the watchdog on the >>> right CPU. >>> >>> Was last discussed here: >>> >>> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-April/095960.html >>> >>> Lets mark it broken until somebody with this hardware gets up and fixes it. >>> >> I must be missing something. What is the point of the remaining patches in this >> case ? > > Indeed. This looks like pointless churn to me, unless someone actually > picks up the driver and fixes it for good. > > If nobody cares enough about it, then maybe it should be moved into > staging and eventually retired... That was a year ago, and nobody has done anything to the driver. Just remove it -- if someone wants to do the work later on it's easy to revert the commit and start over. Keeping code in the kernel but marking it BROKEN is only useful if we think someone will fix it soon. It seems very unlikely in this case. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
