On Friday 31 May 2013 10:58:48 Johannes Thumshirn wrote: > This patch adds the driver for the watchdog devices found on MEN Mikro > Elektronik A21 VMEbus CPU Carrier Boards. It has DT-support and uses the > watchdog framework. > It seems the DT support is rather incomplete > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@xxxxxx> > --- > MAINTAINERS | 6 ++ > drivers/watchdog/Kconfig | 8 ++ > drivers/watchdog/Makefile | 1 + Please add a binding document to Documentation/devicetree/bindings/ > + > +#define GPIO_WD_ENAB 169 > +#define GPIO_WD_FAST 170 > +#define GPIO_WD_TRIG 171 > + > +#define GPIO_RST_CAUSE_BASE 166 You should never hardwire GPIO numbers like this. There is a DT binding for GPIO, so use that to get the number of the tree. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html