Hi Johannes,
> +static int a21_wdt_notify_sys(struct notifier_block *notify, unsigned long code,
> + void *unused)
> +{
> + if (code == SYS_DOWN || code == SYS_HALT)
> + gpio_set_value(GPIO_WD_ENAB, 0);
> +
> + return NOTIFY_DONE;
> +}
> +
> +static struct notifier_block a21_wdt_notifier = {
> + .notifier_call = a21_wdt_notify_sys, };
...
> + ret = register_reboot_notifier(&a21_wdt_notifier);
> + if (ret) {
> + dev_err(&pdev->dev, "Cannot register reboot notifier\n");
> + goto err_register_notif;
> + unregister_reboot_notifier(&a21_wdt_notifier);
...
> + unregister_reboot_notifier(&a21_wdt_notifier);
...
> +static struct platform_driver a21_wdt_driver = {
> + .probe = a21_wdt_probe,
> + .remove = a21_wdt_remove,
> + .driver = {
> + .name = "a21-watchdog",
> + .of_match_table = a21_wdt_ids,
> + },
> +};
I prefer to have the reboot_notifier is being replaced by a platform .shutdown function.
Can you also split the sysfs stuff as a second patch so that I can review that seperately?
Kind regards,
Wim.
Hi Wim,
Of cause I'll do, but unfortunately I probably won't be able to do it today, mind if you get the patch tomorrow?
Regards,
Johannes.
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
