Hi Wolfram, > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxxxxx> Acked-by: Wim Van Sebroeck <wim@xxxxxxxxx> > --- > drivers/watchdog/imx2_wdt.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c > index ff90882..62946c2 100644 > --- a/drivers/watchdog/imx2_wdt.c > +++ b/drivers/watchdog/imx2_wdt.c > @@ -257,11 +257,6 @@ static int __init imx2_wdt_probe(struct platform_device *pdev) > struct resource *res; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "can't get device resources\n"); > - return -ENODEV; > - } > - > imx2_wdt.base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(imx2_wdt.base)) > return PTR_ERR(imx2_wdt.base); Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html