On Tue, Apr 30, 2013 at 10:56:39AM +0900, Jingoo Han wrote: > On Tuesday, April 30, 2013 2:55 AM, Guenter Roeck wrote: > > On Mon, Apr 29, 2013 at 06:35:15PM +0900, Jingoo Han wrote: > > > Use devm_ioremap() to make cleanup paths simpler. > > > > > > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > > > > This patch also addresses the missing call to iounmap() if the call > > to misc_register fails. > > When devm_ioremap() is used, there is no need to call devm_iounmap(). > > It is because, these resource managed functions such as > devm_ioremap() allow the driver core to automatically > clean up any allocation, when probe function fails. > Same response as before. Please read my note above. It says clearly "this patch _addresses_ ...", not "this patch _creates_ ...". Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
