On 03/24/2013 08:12 AM, Lubomir Rintel wrote: > On Fri, 2013-03-22 at 20:24 -0600, Stephen Warren wrote: > > Thank you for your response! > >> On 03/22/2013 06:55 AM, Lubomir Rintel wrote: >>> Signed-off-by: Lubomir Rintel <lkundrak at v3.sk> >> I'm curious where you got the documentation to write this driver; this >> HW module isn't described in BCM2835-ARM-Peripherals.pdf. I assume this >> is based on the downstream kernel driver? If so, at least some credit in >> the commit description might be appropriate. At least the relevant >> commit downstream already has an appropriate Signed-off-by line:-) > > Your guess is right, used bcm2708_wdog driver from rpi-3.6.y as a reference. > I'll add that information to the commit message. > > The Signed-off-by line is indeed present, but unfortunately does not seem to be > particularly appropriate: > > Signed-off-by: popcornmix <popcornmix@xxxxxxxxx> That s-o-b line maps to Dom Cobley. In a previous message on the linux-rpi-kernel mailing list, he gave his permission to re-write the name part of that to "Dom Cobley". That would make the s-o-b useful. http://lists.infradead.org/pipermail/linux-rpi-kernel/2012-September/000154.html -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html