Hi Fabio, > This patch adds support for the ux500_wdt watchdog that is found in > ST-Ericsson Ux500 platform. The driver is based on PRCMU APIs. > > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> > Signed-off-by: Fabio Baltieri <fabio.baltieri@xxxxxxxxxx> > +static int timeout = WATCHDOG_TIMEOUT; > +module_param(timeout, int, 0); > +MODULE_PARM_DESC(timeout, > + "Watchdog timeout in seconds. default=" > + __MODULE_STRING(WATCHDOG_TIMEOUT) "."); We should go for unsigned int timeout values... > +static int nowayout = WATCHDOG_NOWAYOUT; > +module_param(nowayout, int, 0); > +MODULE_PARM_DESC(nowayout, > + "Watchdog cannot be stopped once started (default=" > + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); nowayout is a boolean value so please change this to static bool nowayout = WATCHDOG_NOWAYOUT; The rest is OK by me. So if bowayout get's fixed then you have my acked-by. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
