Hi, > -----Original Message----- > From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx] > Sent: 2012年12月7日 2:16 > To: Yang, Wenyou > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-watchdog@xxxxxxxxxxxxxxx; Lin, JM; > Ferre, Nicolas; linux-kernel@xxxxxxxxxxxxxxx; wim@xxxxxxxxx; > plagnioj@xxxxxxxxxxxx > Subject: Re: [v2 PATCH 6/8] watchdog/at91sam9_wdt: Use > module_platform_driver() > > Hello. > > On 12/05/2012 04:34 AM, Wenyou Yang wrote: > > > Using module_platform_driver() replaces module_init() and module_exit() > > and makes the code simpler. > > > Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxx> > > Cc: wim@xxxxxxxxx > > Cc: linux-watchdog@xxxxxxxxxxxxxxx > > Cc: linux-kernel@xxxxxxxxxxxxxxx > > --- > > drivers/watchdog/at91sam9_wdt.c | 14 ++------------ > > 1 file changed, 2 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c > > index 5afd3fb..a7c0881 100644 > > --- a/drivers/watchdog/at91sam9_wdt.c > > +++ b/drivers/watchdog/at91sam9_wdt.c > > @@ -278,6 +278,7 @@ MODULE_DEVICE_TABLE(of, at91_wdt_dt_ids); > > #endif > > > > static struct platform_driver at91wdt_driver = { > > + .probe = at91wdt_probe, > > You also need to remove '__init' annotation from that function since the > driver becomes hot-plug aware now. Thanks, I got it. > > WBR, Sergei Best Regards, Wenyou Yang ?韬{.n?????%??檩??w?{.n???{??h?Ф?塄}?财??j:+v?? ? ???2??璀??摺?囤??z夸z罐?+?????w棹f
