Hi JC, > -----Original Message----- > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj@xxxxxxxxxxxx] > Sent: 2012年11月16日 21:49 > To: Yang, Wenyou > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; wim@xxxxxxxxx; > linux-watchdog@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Ferre, Nicolas; Lin, > JM > Subject: Re: [PATCH 03/11] watchdog/at91sam9_wdt: change the wdt_read and > wdt_write macro to the inline function > > On 15:16 Wed 14 Nov , Wenyou Yang wrote: > > Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxx> > > --- > > drivers/watchdog/at91sam9_wdt.c | 28 ++++++++++++++++++---------- > > 1 file changed, 18 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c > > index 31c914a..98e7d5a 100644 > > --- a/drivers/watchdog/at91sam9_wdt.c > > +++ b/drivers/watchdog/at91sam9_wdt.c > > @@ -34,11 +34,6 @@ > > > > #define DRV_NAME "AT91SAM9 Watchdog" > > > > -#define wdt_read(field) \ > > - __raw_readl(at91wdt_private.base + field) > > -#define wdt_write(field, val) \ > > - __raw_writel((val), at91wdt_private.base + field) > > - > > /* AT91SAM9 watchdog runs a 12bit counter @ 256Hz, > > * use this to convert a watchdog > > * value from/to milliseconds. > > @@ -75,13 +70,24 @@ struct at91wdt_drvdata { > > > > /* ......................................................................... */ > > > > +static inline unsigned int wdt_read(struct at91wdt_drvdata *driver_data, > > + unsigned int field) > > +{ > > + return __raw_readl(driver_data->base + field); > > +} > > + > > +static inline void wdt_write(struct at91wdt_drvdata *driver_data, > > + unsigned int field, unsigned int val) > > +{ > > + __raw_writel((val), driver_data->base + field); > > +} > use relaxed version Thanks, I will change it. > > Best Regrds, > J. Best Regards, Wenyou Yang ?韬{.n?????%??檩??w?{.n???{??h?Ф?塄}?财??j:+v?? ? ???2??璀??摺?囤??z夸z罐?+?????w棹f
