Re: [PATCH v7 1/3] watchdog: at91sam9_wdt: add device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 2, 2012 at 10:07 PM, Andrew Lunn <andrew@xxxxxxx> wrote:
>> Date: Tue,  2 Oct 2012 18:01:00 +0200
>> From: Fabio Porcedda <fabio.porcedda@xxxxxxxxx>
>> To: Wim Van Sebroeck <wim@xxxxxxxxx>, linux-watchdog@xxxxxxxxxxxxxxx,
>>         linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Nicolas Ferre
>>         <nicolas.ferre@xxxxxxxxx>, Jean-Christophe PLAGNIOL-VILLARD
>>         <plagnioj@xxxxxxxxxxxx>, Andrew Victor <linux@xxxxxxxxxxxx>
>> Cc: devicetree-discuss@xxxxxxxxxxxxxxxx
>> Subject: [PATCH v7 1/3] watchdog: at91sam9_wdt: add device tree
>>         support
>> Message-ID:
>>         <1349193662-23482-2-git-send-email-fabio.porcedda@xxxxxxxxx>
>>
>> Tested on an at91sam9260 board (evk-pro3)
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@xxxxxxxxx>
>> +++ b/drivers/watchdog/at91sam9_wdt.c
>> @@ -32,6 +32,7 @@
>>  #include <linux/timer.h>
>>  #include <linux/bitops.h>
>>  #include <linux/uaccess.h>
>> +#include <linux/of.h>
>>
>>  #include "at91sam9_wdt.h"
>>
>> > @@ -302,11 +303,21 @@ static int __exit at91wdt_remove(struct platform_device *pdev)
>>         return res;
>>  }
>>
>> +#if defined(CONFIG_OF)
>> +static const struct of_device_id at91_wdt_dt_ids[] = {
>> +       { .compatible = "atmel,at91sam9260-wdt" },
>> +       { /* sentinel */ }
>> +};
>
> Hi Fabio
>
> You are missing __devinitdata.

Thank you, Andrew.
I'll add __initconst, because it's const and use platform_driver_probe.

Best regards
-- 
Fabio Porcedda
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux