> I was thinking to add a more generic helper function like this:
>
> static inline void watchdog_get_dttimeout(struct device_node *node,
> u32 *timeout)
> {
> if (node)
> of_property_read_u32(node, "timeout", &wdd->timeout);
> }
You forgot to change the function signature.
Also, if you are adding a generic function, it should be a generic
function for the framework. All drivers should be slowly moving
towards the framework, so adding functions which help you not move
towards the framework are wrong.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
