> Hi Tomas,
>
> > ret = watchdog_dev_register(wdd);
> > if (ret) {
> > - pr_err("error registering /dev/watchdog (err=%d)\n", ret);
> > - return ret;
> > + ida_simple_remove(&watchdog_ida, id);
> > + if (!(id == 0 || ret == -EBUSY))
> > + return ret;
> > +
> > + /* Retry in case a legacy watchdog module exists */
>
> Nope, this should stay
> if (!(id == 0 && ret == -EBUSY))
>
> because we will only retry, if we have the possibility that another legacy
> watchdog is allready there:
> i.e. when the id == 0 and when we have a -EBUSY as a return code.A
You are right... I've wrote the statement (id == 0 || ret == -EBUSY) and then saw the that readability
comment and forgot to change the II into && as well.
Thanks
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
