On 3/7/12, Srinidhi Kasagar <srinidhi.kasagar@xxxxxxxxxxxxxx> wrote: > On Wed, Mar 07, 2012 at 11:27:55 +0100, Viresh KUMAR wrote: >> + wdt->boot_status = (readl(wdt->base + TWD_WDOG_RESETSTAT) & >> + TWD_WDOG_RESETSTAT_MASK) ? WDIOF_CARDRESET : 0; >> + > > I see that patch 12/15 does this, why are you doing it here again in clock > patch? > >> >> - wdt->boot_status = (readl(wdt->base + TWD_WDOG_RESETSTAT) & >> - TWD_WDOG_RESETSTAT_MASK) ? WDIOF_CARDRESET : 0; >> - > > oh, you delete this stuff here again. > > something messy in patch creation? Yes. It does look messy. But it was intentional to move this code up in the function. Will move clk patch before IOCTL addition patch to make it clean. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html