On Thursday 28 July 2011, Joe Perches wrote:
> Perhaps add some logging helpers to the .h?
>
> #define wdd_emerg(wd, fmt, ...) \
> pr_emerg("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__)
> #define wdd_crit(wd, fmt, ...) \
> pr_crit("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__)
> #define wdd_alert(wd, fmt, ...) \
> pr_alert("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__)
> #define wdd_err(wd, fmt, ...) \
> pr_err("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__)
> #define wdd_notice(wd, fmt, ...) \
> pr_notice("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__)
> #define wdd_warn(wd, fmt, ...) \
> pr_warn("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__)
> #define wdd_info(wd, fmt, ...) \
> pr_info("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__)
> #define wdd_dbg(wd, fmt, ...) \
> pr_debug("%s: " fmt, (wd)->info->identity, ##__VA_ARGS__)
No, please don't. Adding driver-specific debugging macros tends to confuse
more than it helps, IMHO.
> > + err = misc_register(&watchdog_miscdev);
> > + if (err != 0) {
> > + pr_err("%s: cannot register miscdev on minor=%d (err=%d).\n",
> > + watchdog->info->identity, WATCHDOG_MINOR, err);
>
> wdd_err(watchdog, "cannot register watchdog on minor %d, err: %d\n",
> WATCHDOG_MINOR, err);
I think changing them could be useful, but I'd rather change them to
dev_err etc and pass the underlying device.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
