On 06/07/11 17:09, Bjorn Helgaas wrote: > I'm looking for comments on these patches. I'm not really happy with > them because they add basically identical code in each driver. I also > don't like the fact that the parameter is not generic, so I have to know > which driver will be used on my machine. Hmm, so this is protecting the window between watchdog_stop and machine_reset. It would be nice to have this as generic code that did WDIOC_SETTIMEOUT immediately after (or instead of) shutdown. Leaving a watchdog enabled across boot does have issues on some systems. It was OK for winboond based watchdogs I tested, but for some IBM server systems, "weird stuff" happened if the watchdog was left enabled across boot. Just to mention the other watchdog boot scenario I often use (which does _not_ protect your window above), which is to enable the watchdog in the BIOS. This is more general protection for the boot _up_ process. On a netboot system for example this will mean that the system will keep rebooting until whatever switch is down etc. is restored. Many systems I've used had support for this in the BIOS and those that didn't were quickly updated by vendors to do so. A related issue I noticed with iTCO_wdt is that something else in the kernel disables the iTCO watchdog (which my BIOS had started). This is undesirable for obvious reasons. cheers, Pádraig. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
