On Wed, Jul 06, 2011 at 09:17:10PM +0200, Wim Van Sebroeck wrote: > Hi Arnd, > > > > +EXPORT_SYMBOL(watchdog_register_device); > > > > How about making this EXPORT_SYMBOL_GPL? > > My opinion: the new framework has been created for 2 reasons: > 1) consolidation of the code that is being repeated in each driver > 2) to make it possible to support more then one driver. > If we want to support more then one driver, then the out-of-tree drivers > would benefit from using the API. Even the non-GPL ones. I strongly support Arnd. And if it helps getting out-of-tree drivers into the tree, great! I'd think most watchdog-drivers are out-of-tree because of laziness, not because of IP? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
