Hi Arnd, On 07/06/2011 03:58 PM, Arnd Bergmann wrote: > On Tuesday 05 July 2011, Vitaly Kuzmichev wrote: >> Signed-off-by: Vitaly Kuzmichev <vkuzmichev@xxxxxxxxxx> >> --- >> drivers/watchdog/mpcore_wdt.c | 26 +------------------------- >> drivers/watchdog/mpcore_wdt.h | 40 ++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 41 insertions(+), 25 deletions(-) >> create mode 100644 drivers/watchdog/mpcore_wdt.h > > I don't see the point in this. IMHO it's better to leave the definitions > in the same file that uses them, because they are not shared across > multiple files. > > If you intend to share them in the future, you should explain that > in the changelog. The patch is aimed to resolve checkpatch warning on "extern" function prototype: WARNING: externs should be avoided in .c files #44: FILE: drivers/watchdog/mpcore_wdt.c:37: +unsigned long twd_timer_get_rate(void); If it's ok to leave this warning I would also like to throw out this patch. Thanks, Vitaly. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
