On Saturday 18 June 2011 19:20:43 Wim Van Sebroeck wrote: > +/* > * watchdog_open: open the /dev/watchdog device. > * @inode: inode of device > * @file: file handle to device > @@ -202,6 +237,7 @@ > .owner = THIS_MODULE, > .llseek = no_llseek, > .write = watchdog_write, > + .unlocked_ioctl = watchdog_ioctl, > .open = watchdog_open, > .release = watchdog_release, > }; All the ioctl commands are compatible with their 32 bit counterparts, so you can just set ".compat_ioctl = watchdog_ioctl" here to slightly speed up the ioctl operation for compat tasks. Looks good otherwise. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html