On Mon, Dec 9, 2024 at 11:16 PM Shijith Thotton <sthotton@xxxxxxxxxxx> wrote: > > Added support to read the vendor-specific PCI capability to identify the > type of device being emulated. > > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Shijith Thotton <sthotton@xxxxxxxxxxx> > --- > drivers/vdpa/octeon_ep/octep_vdpa.h | 20 ++++++++++++++ > drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 33 +++++++++++++++++++++++- > drivers/vdpa/octeon_ep/octep_vdpa_main.c | 4 ++- > 3 files changed, 55 insertions(+), 2 deletions(-) > > diff --git a/drivers/vdpa/octeon_ep/octep_vdpa.h b/drivers/vdpa/octeon_ep/octep_vdpa.h > index 2cadb878e679..53b020b019f7 100644 > --- a/drivers/vdpa/octeon_ep/octep_vdpa.h > +++ b/drivers/vdpa/octeon_ep/octep_vdpa.h > @@ -8,6 +8,7 @@ > #include <linux/pci_regs.h> > #include <linux/vdpa.h> > #include <linux/virtio_pci_modern.h> > +#include <uapi/linux/virtio_crypto.h> > #include <uapi/linux/virtio_net.h> > #include <uapi/linux/virtio_blk.h> > #include <uapi/linux/virtio_config.h> > @@ -52,6 +53,24 @@ struct octep_vring_info { > phys_addr_t notify_pa; > }; > > +enum octep_pci_vndr_cfg_type { > + OCTEP_PCI_VNDR_CFG_TYPE_VIRTIO_ID, > + OCTEP_PCI_VNDR_CFG_TYPE_MAX, > +}; > + > +struct octep_pci_vndr_data { > + struct virtio_pci_vndr_data hdr; > + u8 id; > + u8 bar; > + union { > + u64 data; > + struct { > + u32 offset; > + u32 length; > + }; > + }; > +}; This seems not to be padded to a multiple of 4 bytes? Others look good. Thanks