Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jason Wang <jasowang@xxxxxxxxxx>
Subject: Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect
From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
Date: Wed, 11 Sep 2024 06:30:53 -0400
Cc: Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Eugenio Pérez <eperezma@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, virtualization@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx
In-reply-to: <CACGkMEuN6mFv2NjkA-NFBE2NCt0F1EW5Gk=X0dC4hz45Ns+jhw@mail.gmail.com>
References: <20240820073330.9161-1-xuanzhuo@linux.alibaba.com> <20240820073330.9161-3-xuanzhuo@linux.alibaba.com> <CACGkMEuN6mFv2NjkA-NFBE2NCt0F1EW5Gk=X0dC4hz45Ns+jhw@mail.gmail.com>

On Wed, Sep 11, 2024 at 11:46:30AM +0800, Jason Wang wrote:
> On Tue, Aug 20, 2024 at 3:33 PM Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx> wrote:
> >
> > 1. this commit hardens dma unmap for indirect
> 
> I think we need to explain why we need such hardening.


yes pls be more specific. Recording same state in two
places is just a source of bugs, not hardening.

References:
- [PATCH net-next 00/13] virtio-net: support AF_XDP zero copy (tx)
  - From: Xuan Zhuo
- [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect
  - From: Xuan Zhuo
- Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect
  - From: Jason Wang

Prev by Date: Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API
Next by Date: Re: [PATCH v1 2/7] vhost: Add kthread support in function vhost_worker_queue()
Previous by thread: Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect
Next by thread: Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect
Index(es):
- Date
- Thread

[Index of Archives] [KVM Development] [Libvirt Development] [Libvirt Users] [CentOS Virtualization] [Netdev] [Ethernet Bridging] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]