On Tue, Sep 10, 2024 at 2:29 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > > On Wed, Sep 04, 2024 at 10:11:13AM -0500, Carlos Bilbao wrote: > > From: Carlos Bilbao <cbilbao@xxxxxxxxxxxxxxxx> > > > > Initialize speed and duplex for virtio_net_config to UNKNOWN (mlx5_vdpa > > vDPA devices currently do not support VIRTIO_NET_F_SPEED_DUPLEX). Remove > > ioctl VHOST_VDPA_SET_CONFIG and its related logic as it is not supported; > > see: https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html > > > > Carlos: > > vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN > > vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance > > This will need a rebase. Will apply once you post one. > Thanks! Note that I think patch 2 is probably not right as we indeed allow config write for some device. Thanks