On Fri, 26 Jul 2024 at 01:32, Joe Damato <jdamato@xxxxxxxxxx> wrote:
>
> On Thu, Jul 25, 2024 at 09:31:04AM +0800, Cindy Lu wrote:
> > Add the function to support setting the MAC address.
> > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac
> > to set the mac address
> >
> > Tested in ConnectX-6 Dx device
> >
> > Signed-off-by: Cindy Lu <lulu@xxxxxxxxxx>
> > ---
> > drivers/vdpa/mlx5/net/mlx5_vnet.c | 28 ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > index ecfc16151d61..d7e5e30e9ef4 100644
> > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > @@ -3785,10 +3785,38 @@ static void mlx5_vdpa_dev_del(struct vdpa_mgmt_dev *v_mdev, struct vdpa_device *
> > destroy_workqueue(wq);
> > mgtdev->ndev = NULL;
> > }
>
> Nit: Other code in this file separates functions with newlines,
> perhaps one is needed here?
>
> > +static int mlx5_vdpa_set_attr(struct vdpa_mgmt_dev *v_mdev,
> > + struct vdpa_device *dev,
> > + const struct vdpa_dev_set_config *add_config)
>
> Nit: it appears that the alignment is off on these parameters. Did
> checkpatch.pl --strict pass on this?
>
sure, will check this
thanks
> > +{
> > + struct virtio_net_config *config;
> > + struct mlx5_core_dev *pfmdev;
> > + struct mlx5_vdpa_dev *mvdev;
> > + struct mlx5_vdpa_net *ndev;
>
> [...]
>
