> > -device_param_cb(device, &vm_cmdline_param_ops, NULL, S_IRUSR); > > +device_param_cb(device, &vm_cmdline_param_ops, NULL, 0400); > > What is this warning? It sounds more reasonable to me to go from > hardcoded value to macro, am I missing something? Hey! I believe that the hardcoded value seems better as well. I got the warning from this: ./scripts/checkpatch.pl --file --terse drivers/virtio/virtio_mmio.c ... drivers/virtio/virtio_mmio.c:802: WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. ... I can bring the 'S_IRUSR' again in a V2 patch if you prefer that. > > The rest looks good to me. > > Thanks! > Thanks for taking the time to review! Regards, -Juan
