Re: [PATCH] drm/qxl: Pin buffer objects for internal mappings

[Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>]

On 7/2/24 17:20, Thomas Zimmermann wrote:
> @@ -190,7 +190,13 @@ int qxl_bo_vmap(struct qxl_bo *bo, struct iosys_map *map)
>  	if (r)
>  		return r;
>  
> +	r = qxl_bo_pin_locked(bo);
> +	if (r)
> +		return r;

Is qxl_bo_unreserve() missing here?

> +
>  	r = qxl_bo_vmap_locked(bo, map);
> +	if (r)
> +		qxl_bo_unpin_locked(bo);
>  	qxl_bo_unreserve(bo);
>  	return r;

-- 
Best regards,
Dmitry