On 05/07/2024 13:16, Christoph Hellwig wrote:
if (!lim->logical_block_size)
lim->logical_block_size = SECTOR_SIZE;
+ else if (blk_validate_block_size(lim->logical_block_size))
+ return -EINVAL;
This should print a message. Unfortunately we don't have the device
name here (for that we'd need to set it at disk/queue allocation time,
which will require a bit of work), but even without that it will be
very useful.
Ok, I can print a message, like:
pr_warn("Invalid logical block size (%d)\n", bsize);
I am wary though that userspace could trigger this message from the
various ioctls to set the bsize.
+/* blk_validate_limits() validates bsize, so drivers don't need to */
maybe throw in a usually or normally?
fine
