On 03.07.24 12:40, David Woodhouse wrote: [...] > > > This is what I currently have for 'struct vmclock_abi' that I'd like to > persuade you to adopt. I need to tweak it some more, for at least the > following reasons, as well as any more you can see: > > • size isn't big enough for 64KiB pages > • Should be explicitly little-endian > • Does it need esterror as well as maxerror? I have no opinion about this. I can drop esterror if unwanted. > • Why is maxerror in picoseconds? It's the only use of that unit > • Where do the clock_status values come from? Do they make sense? > • Are signed integers OK? (I think so!). Signed integers would need to be introduced to Virtio, which so far only uses explicitly unsigned types: u8, le16 etc.
