On Sun, Jun 16, 2024 at 02:11:52PM +0800, Lu Baolu wrote: > +static int iommufd_fault_iopf_enable(struct iommufd_device *idev) > +{ > + struct device *dev = idev->dev; > + int ret; > + > + /* > + * Once we turn on PCI/PRI support for VF, the response failure code > + * should not be forwarded to the hardware due to PRI being a shared > + * resource between PF and VFs. There is no coordination for this > + * shared capability. This waits for a vPRI reset to recover. > + */ > + if (dev_is_pci(dev) && to_pci_dev(dev)->is_virtfn) > + return -EINVAL; I don't quite get this remark, isn't not supporting PRI on VFs kind of useless? What is the story here? Jason